Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

302 Fix failed pipelines #306

Merged
merged 9 commits into from
Oct 8, 2024
Merged

302 Fix failed pipelines #306

merged 9 commits into from
Oct 8, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Aug 30, 2024 •
edited
Loading

Fix #302
Still needed this conversation to be resolved for the revdepcheck insightsengineering/r-revdepcheck-action#2

@m7pr m7pr mentioned this pull request Sep 20, 2024
Closed
@m7pr
Copy link
Contributor Author

m7pr commented Oct 3, 2024

Since we provided a fix in insightsengineering/r-revdepcheck-action#4 for the last build, I am opening this PR and restarting the build

@m7pr m7pr marked this pull request as ready for review October 3, 2024 06:51
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ---------
R/tm_g_gh_boxplot.R                        349     349  0.00%    175-591
R/tm_g_gh_correlationplot.R                554     554  0.00%    227-890
R/tm_g_gh_density_distribution_plot.R      276     276  0.00%    135-462
R/tm_g_gh_lineplot.R                       560     560  0.00%    161-815
R/tm_g_gh_scatterplot.R                    244     244  0.00%    144-440
R/tm_g_gh_spaghettiplot.R                  314     314  0.00%    194-590
R/toggleable_slider.R                      154     154  0.00%    72-243
R/utils-arbitrary_lines.r                  125     125  0.00%    19-176
R/utils-data_constraints.r                 190     190  0.00%    2-257
R/utils-keep_range_slider_updated.r         29      29  0.00%    9-45
R/utils-maptrt.r                             9       9  0.00%    24-36
R/utils-templ_ui.r                          66      66  0.00%    2-98
R/utils.R                                   49      49  0.00%    12-112
R/zzz.R                                      2       2  0.00%    2-3
TOTAL                                     2921    2921  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 6046050

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

m7pr
m7pr commented Oct 3, 2024
View reviewed changes
.github/workflows/scheduled.yaml Outdated Show resolved Hide resolved
@m7pr
Copy link
Contributor Author

m7pr commented Oct 3, 2024

Checks are failiing as there is external cairo dependency missing. Raised this to IDR for help

teal.goshawk requires external debian dependency to be installed
https://github.com/insightsengineering/teal.goshawk/actions/runs/11158031696/job/31013452052#step:7:6452

@m7pr m7pr mentioned this pull request Oct 3, 2024
Merged
@m7pr
Copy link
Contributor Author

m7pr commented Oct 8, 2024

Since this was resolved in r-hub/actions r-lib/pak#702
and the restarted job is green now, I think we are ready to get this merged.

The r-hub job and revdepcheck are green https://github.com/insightsengineering/teal.goshawk/actions/runs/11161819395/job/31217734588

@m7pr m7pr requested review from pawelru and donyunardi October 8, 2024 09:00
pawelru
pawelru approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pawelru pawelru self-assigned this Oct 8, 2024
@m7pr m7pr merged commit 5a49a9c into main Oct 8, 2024
29 checks passed
@m7pr m7pr deleted the fix-pipelines@main branch October 8, 2024 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pawelru pawelru pawelru approved these changes

@donyunardi donyunardi Awaiting requested review from donyunardi

Assignees

@pawelru pawelru

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failed pipeline
3 participants
@m7pr @pawelru @walkowif